Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: clean up memory handling #542

Closed
wants to merge 3 commits into from
Closed

java: clean up memory handling #542

wants to merge 3 commits into from

Conversation

axic
Copy link
Member

@axic axic commented Sep 29, 2020

Base automatically changed from java-cleanup to master September 30, 2020 09:27
@atoulme
Copy link
Collaborator

atoulme commented Sep 30, 2020

I ran the VM reference tests against the EVM in a continuous loop for several hours and didn't notice a leak. It's cool to dispose of memory explicitly. I believe the JVM disposes of ByteBuffer objects it creates through garbage collection otherwise.

@axic
Copy link
Member Author

axic commented Oct 8, 2020

I ran the VM reference tests against the EVM in a continuous loop for several hours and didn't notice a leak. It's cool to dispose of memory explicitly. I believe the JVM disposes of ByteBuffer objects it creates through garbage collection otherwise.

My impression from the documentation was that these objects are part of garbage collection, but owned by the JNI interface, hence they need to be freed. They are not large objects however, so I can imagine it can lasts days before OOM.

Can you point me to the documentation where this is clarified?

Also note some of the memory freeing is already part of the code, it is inconsistent.

@atoulme
Copy link
Collaborator

atoulme commented Oct 9, 2020

OK, I think I'm wrong here. You're right, let's dispose of memory explicitly.

@axic
Copy link
Member Author

axic commented Mar 17, 2024

With #706 Java support was dropped -- closing this.

@axic axic closed this Mar 17, 2024
@axic axic deleted the java-memory branch March 17, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants