Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dankrad altair review -- extended and tested #2399

Merged
merged 24 commits into from
May 12, 2021
Merged

dankrad altair review -- extended and tested #2399

merged 24 commits into from
May 12, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 10, 2021 •
edited
Loading

supersedes @dankrad's #2387

  • remove double applied non-quadratic leak
  • add PARTICIPATION_FLAG_WEIGHTS and update logic in favor of get_flag_indices_and_weights
  • Remove timely-head penalty, only reward now
  • fix a couple of minor comments

dankrad and others added 16 commits May 5, 2021 12:05
@dankrad
Flags to BitVector
786e611
@dankrad
BitVector -> Bitvector
df6bd1b
@dankrad
Correct confusing comments in "get_sync_committee_indices"
238a9b0
@dankrad
Refactor participation flag list
a382cf6
@dankrad
Update toc
227d100
@dankrad
Remove extra variable
687641a
@dankrad
Revert "BitVector -> Bitvector"
55471bc 
This reverts commit df6bd1b.
@dankrad
Revert "Flags to BitVector"
7752403 
This reverts commit 786e611.

# Conflicts:
#	specs/altair/beacon-chain.md
@dankrad
Further flag_index revert
b041a9b
@dankrad
Remove duplicate inactivity leak
cbf9f85
@dankrad
No inactivity penalty for untimely head
cf724da
@dankrad
Integrate get_inactivity_penalty_deltas into reward computation for b…
81a8c27 
…etter readability
@dankrad
Remove PARTICIPATION_FLAGS
ba2c717
@dankrad @ralexstokes
Update specs/altair/beacon-chain.md
2fc68c4 
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@djrtwo
Merge branch 'dev' into dankrad-altair-review
95e2aa6
@djrtwo
lint
cd78425
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from 6c1ee31 to f0821c7 Compare May 10, 2021 17:11
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from f0821c7 to 1494fe6 Compare May 10, 2021 18:21
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from e8ec516 to 8608ab1 Compare May 10, 2021 19:47
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from 8608ab1 to a6b8574 Compare May 10, 2021 22:18
@djrtwo djrtwo added this to the v1.1.0-alpha.4 milestone May 11, 2021
@hwwhww hwwhww added the Altair aka HF1 label May 11, 2021
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from 6b03fc4 to a2e1cbc Compare May 11, 2021 17:45
@djrtwo djrtwo changed the base branch from dankrad-altair-review to dev May 11, 2021 17:45
@djrtwo djrtwo force-pushed the keep-inactivity-function branch from a2e1cbc to a9cc036 Compare May 11, 2021 17:48
@djrtwo djrtwo mentioned this pull request May 11, 2021
Closed
@djrtwo djrtwo mentioned this pull request May 11, 2021
Merged
@djrtwo djrtwo changed the title add get_inactivity_penalty_deltas back in dankrad altair review -- extended and tested May 11, 2021
@djrtwo @hwwhww
Apply suggestions from code review
6371707 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@djrtwo djrtwo merged commit 51a5474 into dev May 12, 2021
@djrtwo djrtwo deleted the keep-inactivity-function branch May 12, 2021 18:38
@twoeths twoeths mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww left review comments

@dankrad dankrad dankrad left review comments

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
Altair aka HF1
Projects
None yet
Milestone
v1.1.0-alpha.4
Development

Successfully merging this pull request may close these issues.
4 participants
@djrtwo @ralexstokes @dankrad @hwwhww