Dankrad altair review

[dankrad]

No description provided.

[dankrad]

I made some changes to reward/penalty calculation:

Non-substantive:

• I feel like it's not that productive to have the separate "get_inactivity_penalty_deltas" function? Shouldn't we just integrate it into get_flag_index_deltas for the target flag? The two functions are actually kind of tightly dependent on each other and I think they are actually easier to read if integrated

Substantive:

• I think the non-quadratic inactivity leak is actually applied twice — once in the last "else" branch of get_flag_index_deltas, and once in the first branch of get_inactivity_penalty_deltas, where the comment says "# This inactivity penalty cancels the flag reward corresponding to the flag index". I think this doesn't make sense. I would simply remove the penalty in get_inactivity_penalty_deltas, and not apply any reward in this case.
• I think in the past we discussed how it is annoying that you can't break even in the inactivity leak, because it's impossible to get your attestation in in time (after all, in expectation at least 1/3 of slots are missing). This still isn't fixed — we apply the full penalty for timely head even though it's out of the control of the attester. I suggest not punishing for an untimely head in the inactivity leak

[ralexstokes]

no comment yet on the rewards refactor but generally support the flags refactor

[djrtwo]

closing in favor of #2399