Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12 #6503

Closed
wants to merge 2 commits into from
Closed

Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12 #6503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366df1a
Update EIP-4844: Sync `MAX_VERSIONED_HASHES_LIST_SIZE` to 2**12
etan-status Feb 15, 2023
a3eac25
Merge branch 'master' into tx-syncblobslimit
etan-status Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EIPS/eip-4844.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Compared to full data sharding, this EIP has a reduced cap on the number of thes
| `TARGET_DATA_GAS_PER_BLOCK` | `2**18` |
| `MIN_DATA_GASPRICE` | `1` |
| `DATA_GASPRICE_UPDATE_FRACTION` | `2225652` |
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**24` |
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |
| `MAX_TX_VERSIONED_HASHES_LIST_SIZE` | `2**12` |

should we also add _TX_ to sort of correspond with other limits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think aligning the values and renaming them should be separate discussions / PRs.

| `MAX_CALLDATA_SIZE` | `2**24` |
| `MAX_ACCESS_LIST_SIZE` | `2**24` |
| `MAX_ACCESS_LIST_STORAGE_KEYS` | `2**24` |
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-6404.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Definitions from existing specifications that are used throughout this document
| [`MAX_CALLDATA_SIZE`](./eip-4844.md#parameters) | `uint64(2**24)` (= 16,777,216) |
| [`MAX_ACCESS_LIST_STORAGE_KEYS`](./eip-4844.md#parameters) | `uint64(2**24)` (= 16,777,216) |
| [`MAX_ACCESS_LIST_SIZE`](./eip-4844.md#parameters) | `uint64(2**24)` (= 16,777,216) |
| [`MAX_VERSIONED_HASHES_LIST_SIZE`](./eip-4844.md#parameters) | `uint64(2**24)` (= 16,777,216) |
| [`MAX_VERSIONED_HASHES_LIST_SIZE`](./eip-4844.md#parameters) | `uint64(2**12)` (= 16,777,216) |

### [EIP-2718](./eip-2718.md) transaction types

Expand Down