Update EIP-4844: Sync MAX_VERSIONED_HASHES_LIST_SIZE to 2**12
#6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align `MAX_VERSIONED_HASHES_LIST_SIZE` with `LIMIT_BLOBS_PER_TX` and `MAX_TX_WRAP_KZG_COMMITMENTS` changes from ethereum#6500. ```python assert len(versioned_hashes) == len(commitments) == len(blobs) ```
github-actions
bot
added
c-update
File
|
g11tech
reviewed
May 1, 2023
| @@ -49,7 +49,7 @@ Compared to full data sharding, this EIP has a reduced cap on the number of thes | |||
| | `TARGET_DATA_GAS_PER_BLOCK` | `2**18` | | |||
| | `MIN_DATA_GASPRICE` | `1` | | |||
| | `DATA_GASPRICE_UPDATE_FRACTION` | `2225652` | | |||
| | `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**24` | | |||
| | `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` | | |||
There was a problem hiding this comment.
Suggested change
| | `MAX_VERSIONED_HASHES_LIST_SIZE` | `2**12` | | |
| | `MAX_TX_VERSIONED_HASHES_LIST_SIZE` | `2**12` | |
should we also add _TX_ to sort of correspond with other limits?
There was a problem hiding this comment.
Hmm, I think aligning the values and renaming them should be separate discussions / PRs.
g11tech
approved these changes
May 2, 2023
|
I think an approval is required from one of the authors |
|
closing this as we are no longer pursuing SSZ in 4844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align
MAX_VERSIONED_HASHES_LIST_SIZEwithLIMIT_BLOBS_PER_TXandMAX_TX_WRAP_KZG_COMMITMENTSchanges from #6500.