Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2481: Testcases + proposed change to GetBlockHeaders #3228

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 28, 2021

This PR adds testcase for each of the messages that were redefined as part of eth/66.
Since at the time of creating this PR, there are no clients that have implemented these messages, it would be good if the rlp-encoding of the mssages could be properly defined in the specification, and possibly also that others can verify these rlp blobs.

This PR also proposes a change to the RLP-format of GetBlockHeaders.

Before this change:
EDIT: This is now the 'correct' way, unchanged from the original spec:

rlpdump -hex 0xca820457c682270f050580

[
  0457,
  [
    270f,
    05,
    05,
    "",
  ],
]

After this change:
EDIT: The example below is moot:

rlpdump -hex c982045782270f050580
[
  0457,
  270f,
  05,
  05,
  "",
]

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

@holiman holiman changed the title EIP-2481: add testcases EIP-2481: Testcases + proposed change to GetBlockHeaders Jan 28, 2021
@holiman
Copy link
Contributor Author

holiman commented Feb 5, 2021

  • I removed the reference to les,
  • Testcases regenerated
  • Removed the example from the abstract (the actual spec is just a little bit further down, seems unnecessary to duplicate things into the abstract)

Copy link
Contributor

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes. LGTM 👍

@holiman holiman merged commit de2fbc8 into ethereum:master Feb 8, 2021
Arachnid pushed a commit to Arachnid/EIPs that referenced this pull request Mar 6, 2021
* EIP-2481: add testcases

* EIP-2481: propose unpacking of GetHeadersPacket

* EIP-2481: revert spec changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants