EIP-2481: Testcases + proposed change to GetBlockHeaders
#3228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testcase for each of the messages that were redefined as part of
eth/66
.Since at the time of creating this PR, there are no clients that have implemented these messages, it would be good if the rlp-encoding of the mssages could be properly defined in the specification, and possibly also that others can verify these rlp blobs.
This PR also proposes a change to the RLP-format ofGetBlockHeaders
.Before this change:EDIT: This is now the 'correct' way, unchanged from the original spec:
After this change:EDIT: The example below is moot: