forked from ethereum/EIPs
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Upgrade @openzeppelin/contracts from 4.5.0 to 4.6.0 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-COMMONMARKER-2415031 - https://snyk.io/vuln/SNYK-RUBY-KRAMDOWN-1087436 - https://snyk.io/vuln/SNYK-RUBY-KRAMDOWN-585939 - https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-2413994 - https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-2620374 - https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-2630623 - https://snyk.io/vuln/SNYK-RUBY-NOKOGIRI-2630898
…f40be1a2f7 [Snyk] Fix for 7 vulnerabilities
Snyk has created this PR to upgrade @types/mocha from 9.1.0 to 9.1.1. See this package in npm: https://www.npmjs.com/package/@types/mocha See this project in Snyk: https://app.snyk.io/org/woodpile37/project/72e9c1b2-d733-44b3-a24c-7eae36d94744?utm_source=github&utm_medium=referral&page=upgrade-pr
…5dfac07523754d
Snyk has created this PR to upgrade @openzeppelin/contracts from 4.5.0 to 4.6.0. See this package in npm: https://www.npmjs.com/package/@openzeppelin/contracts See this project in Snyk: https://app.snyk.io/org/woodpile37/project/72e9c1b2-d733-44b3-a24c-7eae36d94744?utm_source=github&utm_medium=referral&page=upgrade-pr
Woodpile37
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
Woodpile37
approved these changes
Aug 16, 2023
Woodpile37
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade @openzeppelin/contracts from 4.5.0 to 4.6.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Release notes
Package name: @openzeppelin/contracts
crosschain
: Add a new set of contracts for cross-chain applications.CrossChainEnabled
is a base contract with instantiations for several chains and bridges, andAccessControlCrossChain
is an extension of access control that allows cross-chain operation. (#3183)AccessControl
: add a virtual_checkRole(bytes32)
function that can be overridden to alter theonlyRole
modifier behavior. (#3137)EnumerableMap
: add newAddressToUintMap
map type. (#3150)EnumerableMap
: add newBytes32ToBytes32Map
map type. (#3192)ERC20FlashMint
: support infinite allowance when paying back a flash loan. (#3226)ERC20Wrapper
: thedecimals()
function now tries to fetch the value from the underlying token instance. If that calls revert, then the default value is used. (#3259)draft-ERC20Permit
: replaceimmutable
withconstant
for_PERMIT_TYPEHASH
since thekeccak256
of string literals is treated specially and the hash is evaluated at compile time. (#3196)ERC1155
: Add a_afterTokenTransfer
hook for improved extensibility. (#3166)ERC1155URIStorage
: add a new extension that implements a_setURI
behavior similar to ERC721's_setTokenURI
. (#3210)DoubleEndedQueue
: a new data structure that supports efficient push and pop to both front and back, useful for FIFO and LIFO queues. (#3153)Governor
: improved security ofonlyGovernance
modifier when using an external executor contract (e.g. a timelock) that can operate without necessarily going through the governance protocol. (#3147)Governor
: Add a way to parameterize votes. This can be used to implement voting systems such as fractionalized voting, ERC721 based voting, or any number of other systems. Theparams
argument added to_countVote
method, and included in the newly added_getVotes
method, can be used by counting and voting modules respectively for such purposes. (#3043)Governor
: rewording of revert reason for consistency. (#3275)Governor
: fix an inconsistency in data locations that could lead to invalid bytecode being produced. (#3295)Governor
: ImplementIERC721Receiver
andIERC1155Receiver
to improve token custody by governors. (#3230)TimelockController
: ImplementIERC721Receiver
andIERC1155Receiver
to improve token custody by timelocks. (#3230)TimelockController
: Add a separate canceller role for the ability to cancel. (#3165)Initializable
: add a reinitializer modifier that enables the initialization of new modules, added to already initialized contracts through upgradeability. (#3232)Initializable
: add an Initialized event that tracks initialized version numbers. (#3294)ERC2981
: makeroyaltiInfo
public to allow super call in overrides. (#3305)Upgradeability notice
TimelockController
: (Action needed) The upgrade from <4.6 to >=4.6 introduces a newCANCELLER_ROLE
that requires set up to be assignable. After the upgrade, only addresses with this role will have the ability to cancel. Proposers will no longer be able to cancel. Assigning cancellers can be done by an admin (including the timelock itself) once the role admin is set up. To do this, we recommend upgrading to theTimelockControllerWith46MigrationUpgradeable
contract and then calling themigrateTo46
function.Breaking changes
Governor
: Adds internal virtual_getVotes
method that must be implemented; this is a breaking change for existing concrete extensions toGovernor
. To fix this on an existing voting module extension, renamegetVotes
to_getVotes
and add abytes memory
argument. (#3043)Governor
: Addsparams
parameter to internal virtual_countVote
method; this is a breaking change for existing concrete extensions toGovernor
. To fix this on an existing counting module extension, add abytes memory
argument to_countVote
. (#3043)Governor
: Does not emitVoteCast
event when params data is non-empty; instead emitsVoteCastWithParams
event. To fix this on an integration that consumes theVoteCast
event, also fetch/monitorVoteCastWithParams
events. (#3043)Votes
: The internal virtual function_getVotingUnits
was madeview
(which was accidentally missing). Any overrides should now be updated so they areview
as well.This prerelease is now available for open review! Let us know your feedback and if you find any security issues.
We have a bug bounty with rewards of up to USD $25,000 and a special POAP for submitting a valid issue.
See the announcement for some more details.
ERC2981
: add implementation of the royalty standard, and the respective extensions forERC721
andERC1155
. (#3012)GovernorTimelockControl
: improve thestate()
function to have it reflect cases where a proposal has been canceled directly on the timelock. (#2977)Governor
: add a relay function to help recover assets sent to a governor that is not its own executor (e.g. when using a timelock). (#2926)GovernorPreventLateQuorum
: add new module to ensure a minimum voting duration is available after the quorum is reached. (#2973)ERC721
: improved revert reason when transferring from wrong owner. (#2975)Votes
: Added a base contract for vote tracking with delegation. (#2944)ERC721Votes
: Added an extension of ERC721 enabled with vote tracking and delegation. (#2944)ERC2771Context
: use immutable storage to store the forwarder address, no longer an issue since Solidity >=0.8.8 allows reading immutable variables in the constructor. (#2917)Base64
: add a library to parse bytes into base64 strings usingencode(bytes memory)
function, and provide examples to show how to use to build URL-safetokenURIs
. (#2884)ERC20
: reduce allowance before triggering transfer. (#3056)ERC20
: do not update allowance ontransferFrom
when allowance istype(uint256).max
. (#3085)ERC20
: add a_spendAllowance
internal function. (#3170)ERC20Burnable
: do not update allowance onburnFrom
when allowance istype(uint256).max
. (#3170)ERC777
: do not update allowance ontransferFrom
when allowance istype(uint256).max
. (#3085)ERC777
: add a_spendAllowance
internal function. (#3170)SignedMath
: a new signed version of the Math library withmax
,min
, andaverage
. (#2686)SignedMath
: add aabs(int256)
method that returns the unsigned absolute value of a signed value. (#2984)ERC1967Upgrade
: Refactor the secure upgrade to useERC1822
instead of the previous rollback mechanism. This reduces code complexity and attack surface with similar security guarantees. (#3021)UUPSUpgradeable
: AddERC1822
compliance to support the updated secure upgrade mechanism. (#3021)Breaking changes
ERC1967Upgrade
: The function_upgradeToAndCallSecure
was renamed to_upgradeToAndCallUUPS
, along with the change in security mechanism described above.Address
: The Solidity pragma is increased from^0.8.0
to^0.8.1
. This is required by theaccount.code.length
syntax that replaces inline assembly. This may require users to bump their compiler version from0.8.0
to0.8.1
or later. Note that other parts of the code already include stricter requirements.Commit messages
Package name: @openzeppelin/contracts
GetBlockHeaders
ethereum/EIPs#3228)Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs