Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to affected EIP #2251

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Add reference to affected EIP #2251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38f7837
Add reference to affected EIP
fulldecent Aug 27, 2019
841f1d4
Add detail for ERC-165 impact analysis
fulldecent Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions EIPS/eip-1884.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ The changes require a hardfork. The changes have the following consequences:
- Certain calls will become more expensive.
- Default-functions which access the storage and may in some cases require more than`2300` gas (the minimum gas that is always available in calls).
- Contracts that assume a certain fixed gas cost for calls (or internal sections) may cease to function.
- A fixed gas cost is specified in [ERC-165](https://eips.ethereum.org/EIPS/eip-165) and implementations of this interface do use the affected opcodes.
fulldecent marked this conversation as resolved.
Show resolved Hide resolved
- The ERC-165 method `supportsInterface` must return a `bool` and use at most `30,000` gas.
- The two example implementations from the EIP were, at the time of writing
1. `586` gas for any input, and
2. `236` gas, but increases linearly with a higher number of supported interfaces
- It is unlikely that any ERC-165 `supportsInterface` implementation will go above `30.000` gas. That would require that the second variant is used, and thirty:ish interfaces are supported.
- However, these operations have already been repriced earlier, so there is a historical precedent that 'the gascost for these operations may change', which should have prevented such fixed-gas-cost assumptions from being implemented.

I expect that certain patterns will be less used, for example the use of multiple modifiers which `SLOAD`s the same opcode will be merged into one. It may also lead to less `log` operations containing `SLOAD`ed values that are not strictly necessary.
Expand Down