Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to affected EIP #2251

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Add reference to affected EIP #2251

merged 2 commits into from
Aug 31, 2019

Conversation

fulldecent
Copy link
Contributor

Adding reference for backwards compatibility issue on affected EIP

@eip-automerger
Copy link

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

  • EIP 1884 requires approval from one of (@holiman)

holiman
holiman reviewed Aug 27, 2019
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some info, I didn't know about that myself. I'd like to add some more detailed analysis. cc @Arachnid , PTAL if this seems correct

EIPS/eip-1884.md Show resolved Hide resolved
@fulldecent @holiman
Add detail for ERC-165 impact analysis
841f1d4 
Co-Authored-By: Martin Holst Swende <martin@swende.se>
@fulldecent
Copy link
Contributor Author

@holiman looks great, thank you, added

@eip-automerger eip-automerger merged commit 7c5b41d into ethereum:master Aug 31, 2019
@holiman holiman mentioned this pull request Aug 31, 2019
Closed
@Kaykutee Kaykutee mentioned this pull request Sep 1, 2019
Merged
ilanolkies pushed a commit to ilanolkies/EIPs that referenced this pull request Nov 12, 2019
@fulldecent @ilanolkies
Automatically merged updates to draft EIP(s) 1884 (ethereum#2251)
1ebff99 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
MadeofTin pushed a commit to MadeofTin/EIPs that referenced this pull request Nov 13, 2019
@fulldecent @MadeofTin
Automatically merged updates to draft EIP(s) 1884 (ethereum#2251)
5779366 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
BelfordZ pushed a commit to BelfordZ/EIPs that referenced this pull request Dec 13, 2019
@fulldecent @BelfordZ
Automatically merged updates to draft EIP(s) 1884 (ethereum#2251)
da8c9f3 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
tkstanczak pushed a commit to tkstanczak/EIPs that referenced this pull request Nov 7, 2020
@fulldecent @tkstanczak
Automatically merged updates to draft EIP(s) 1884 (ethereum#2251)
9498d2b 
Hi, I'm a bot! This change was automatically merged because:

 - It only modifies existing Draft or Last Call EIP(s)
 - The PR was approved or written by at least one author of each modified EIP
 - The build is passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulldecent @eip-automerger @holiman