[3.5] Fix tx buffer inconsistency if there are duplicate keys in one tx. #17239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ahrtr @serathius |
ahrtr
previously approved these changes
Jan 12, 2024
serathius
requested changes
Jan 16, 2024
siyuanfoundation
force-pushed
the
txBuf-3.5
branch
from
08b5d3d
to
35d55a8
Compare
Signed-off-by: Siyuan Zhang <sizhang@google.com>
…bucket. Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
txBuf-3.5
branch
from
35d55a8
to
4142d49
Compare
ahrtr
dismissed
their stale review
proposed to revert the change on main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Backport #17228 to 3.5
related to #17158