Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guide to ensure there is an associated issue for each PR #17234

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update contributing guide to ensure there is an associated issue for each PR #17234

merged 1 commit into from
Jan 12, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 12, 2024

@ahrtr ahrtr mentioned this pull request Jan 12, 2024
Merged
@ahrtr
update contributing guide to ensure there is an associated issue for …
f7d264d 
…each PR

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
fuweid
fuweid approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ahrtr ahrtr merged commit b2cc2fb into etcd-io:main Jan 12, 2024
39 checks passed
@ahrtr ahrtr deleted the contribution_20240112 branch June 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrtr @serathius @fuweid