Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webserver unresponsiveness #5259

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Fix webserver unresponsiveness #5259

merged 1 commit into from
Oct 18, 2018

Conversation

ascillato
Copy link
Contributor

@earlephilhower
Copy link
Collaborator

Thanks, beat me by a couple seconds!

earlephilhower
earlephilhower approved these changes Oct 18, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @d-a-v can you verify that we don't want the same change at line 459 (where there is another "esp_yield()" in a while(1) loop.

@ascillato
Copy link
Contributor Author

ascillato commented Oct 18, 2018 •
edited
Loading

@earlephilhower

I have tested also the change of line 459 to delay(0) and webserver works.
Not a noticeable difference using delay(0) or esp_yield() in that line.

You want me to perform another test?

d-a-v
d-a-v approved these changes Oct 18, 2018
View reviewed changes
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this esp_yield() is associated with esp_schedule() in L530.
Anyway this part of the code has not been modified since ages so I think we are safe here.

@devyte devyte merged commit 561426c into esp8266:master Oct 18, 2018
@ascillato ascillato deleted the patch-1 branch October 18, 2018 21:41
@ascillato ascillato mentioned this pull request Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ascillato @earlephilhower @d-a-v @devyte