Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: WiFiClient::flush() yields but can be called from events (#5254)
Fix bug introduced by #5167 which replaced delay() by yield(). That should have been esp_yield() which is the one delay() calls and is safe from either SYS or CONT contexts. Fixes #5237.
- Loading branch information
e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi
@d-a-v, @earlephilhower
We have done several tests and we found that this last commit make the device unresponsive to webserver.
Reverting to ad7cb63 all works again.
Please, could you revert this last commit?
e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ascillato sorry to hear that. Can you try using
instead of going back to
delay()
and see if that clears your issue up?yield()
is not allowed in SYS context (which can also use this routine). -edit- typo here <---e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will test
e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh, my suggested code is actually the exact same as
delay(0);
So ignore that, try delay(0), please.e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will try
e549355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
delay(0)
works fine !!!!Tested webserver and OTA URL. All fine.