-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable C3, H2, S2 and S3 HIL #1513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - however I'm a noob in regards to CI
cab6d7e
to
f123d1b
Compare
f6b7595
to
1308dda
Compare
Converted to draft as |
84080a1
to
37a78af
Compare
f7899ab
to
112d1d2
Compare
54f2778
to
e1d8730
Compare
Disabled the following test for the following targets:
All the issues are covered in #1509 and #1524 HIL are now running green: https://github.com/esp-rs/esp-hal/actions/runs/8891148274 so this should be ready fore review again! |
- name: Run tests | ||
path: tests-${{ matrix.target.soc }} | ||
|
||
- name: Run Tests | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would really like to see this implemented in the xtask
instead, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, this bash code and the one preparing the artifacts looks quite bad to me. Any suggestions on how to integrate this with xtask
other than creating a subcommand that points to a folder, and it executes all the elfs on that folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a subcommand to run all the elfs in a folder in daf8746
. Here is a HIL run: https://github.com/esp-rs/esp-hal/actions/runs/8924001488 with that changes, it increases the time it takes for the run as it needs to build the xtask package.
@@ -78,12 +81,12 @@ jobs: | |||
base_name="$(basename "$file" | cut -d'-' -f1)" | |||
mv "$file" "tests/$base_name" | |||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tested with cargo build --out-dir...
but since the elfs are generated under the target/.../deps
and are not the "final" artifacts it does not help. My idea was to modify cargo xtast build-tests
to add the --out-dir
argument and avoid all this bash code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one nitpick comment, sorry. Not going to approve so it's not accidentally merged before remaining discussion threads are resolved.
6eb6a04
to
daf8746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
probe-rs
being used.Limitations
Some test are disabled for some targets, see: #1524 and #1509
Important
Once merged we need to add the
HIL Test | esp32c3
,HIL Test | esp32h2
,HIL Test | esp32s2
andHIL Test | esp32s3
test to the required checksTesting
Manually triggered the HIL tests workflow: https://github.com/esp-rs/esp-hal/actions/runs/8891148274