Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable C3, H2, S2 and S3 HIL #1513

Merged
merged 17 commits into from
May 2, 2024
Merged

Enable C3, H2, S2 and S3 HIL #1513

merged 17 commits into from
May 2, 2024

Conversation

SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Apr 26, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

  • Enables C3, H2, S2 and S3 HIL.
  • Updates the version of probe-rs being used.
Limitations

Some test are disabled for some targets, see: #1524 and #1509

Important

Once merged we need to add the HIL Test | esp32c3, HIL Test | esp32h2, HIL Test | esp32s2 and HIL Test | esp32s3 test to the required checks

Testing

Manually triggered the HIL tests workflow: https://github.com/esp-rs/esp-hal/actions/runs/8891148274

@SergioGasquez SergioGasquez added the skip-changelog No changelog modification needed label Apr 26, 2024
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - however I'm a noob in regards to CI

hil-test/tests/uart.rs Outdated Show resolved Hide resolved
@SergioGasquez SergioGasquez marked this pull request as draft April 26, 2024 13:22
@SergioGasquez
Copy link
Member Author

SergioGasquez commented Apr 26, 2024

Converted to draft as uart is now failing for C3 after the rebase, will investigate the issue. Seems like, when using the RcFast clock source, the code just hangs in https://github.com/esp-rs/esp-hal/blob/main/esp-hal/src/uart.rs#L1108 and then, the test times out.

@SergioGasquez SergioGasquez force-pushed the feat/rpi-runners branch 2 times, most recently from 84080a1 to 37a78af Compare April 29, 2024 11:54
@SergioGasquez SergioGasquez changed the title Enable C3, S2 and S3 HIL Enable C3, H2, S2 and S3 HIL Apr 29, 2024
@SergioGasquez SergioGasquez marked this pull request as ready for review April 30, 2024 08:03
@SergioGasquez
Copy link
Member Author

SergioGasquez commented Apr 30, 2024

Disabled the following test for the following targets:

  • delay: H2 and S2
  • spi_full_duplex_dma: S2

All the issues are covered in #1509 and #1524

HIL are now running green: https://github.com/esp-rs/esp-hal/actions/runs/8891148274 so this should be ready fore review again!

@SergioGasquez SergioGasquez linked an issue Apr 30, 2024 that may be closed by this pull request
hil-test/tests/uart_async.rs Outdated Show resolved Hide resolved
hil-test/tests/spi_full_duplex_dma.rs Outdated Show resolved Hide resolved
hil-test/tests/delay.rs Outdated Show resolved Hide resolved
- name: Run tests
path: tests-${{ matrix.target.soc }}

- name: Run Tests
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would really like to see this implemented in the xtask instead, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, this bash code and the one preparing the artifacts looks quite bad to me. Any suggestions on how to integrate this with xtask other than creating a subcommand that points to a folder, and it executes all the elfs on that folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a subcommand to run all the elfs in a folder in daf8746. Here is a HIL run: https://github.com/esp-rs/esp-hal/actions/runs/8924001488 with that changes, it increases the time it takes for the run as it needs to build the xtask package.

@@ -78,12 +81,12 @@ jobs:
base_name="$(basename "$file" | cut -d'-' -f1)"
mv "$file" "tests/$base_name"
done
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also tested with cargo build --out-dir... but since the elfs are generated under the target/.../deps and are not the "final" artifacts it does not help. My idea was to modify cargo xtast build-tests to add the --out-dir argument and avoid all this bash code.

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one nitpick comment, sorry. Not going to approve so it's not accidentally merged before remaining discussion threads are resolved.

hil-test/README.md Outdated Show resolved Hide resolved
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jessebraham jessebraham added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit edd0371 May 2, 2024
53 checks passed
@MabezDev MabezDev deleted the feat/rpi-runners branch May 2, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIL fix test suite
4 participants