Skip to content

Commit

Permalink
Addressing reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
playfulFence committed Sep 4, 2024
1 parent 26230a0 commit 5b56aa7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
7 changes: 3 additions & 4 deletions hil-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ The [`hil.yml`] workflow builds the test suite for all our available targets and
Our self-hosted runners have the following setup:
- ESP32-C2 (`esp32c2-jtag`):
- Devkit: `ESP8684-DevKitM-1` connected via UART.
- `GPIO18` and `GPIO19` are I2C pins.
- `GPIO18` and `GPIO9` are I2C pins.
- `GPIO2` and `GPIO3` are connected.
- Probe: `ESP-Prog` connected with the [following connections][connection_c2]
- RPi: Raspbian 12 configured with the following [setup]
Expand All @@ -85,15 +85,14 @@ Our self-hosted runners have the following setup:
- RPi: Raspbian 12 configured with the following [setup]
- ESP32-H2 (`esp32h2-usb`):
- Devkit: `ESP32-H2-DevKitM-1` connected via USB-Serial-JTAG (`USB` port).
- `GPIO4` and `GPIO22` are I2C pins.
- `GPIO12` and `GPIO22` are I2C pins.
- `GPIO2` and `GPIO3` are connected.
- `GPIO5` and `GPIO8` are connected.
- `GPIO4` and `GPIO5` are connected.
- RPi: Raspbian 12 configured with the following [setup]
- ESP32-S2 (`esp32s2-jtag`):
- Devkit: `ESP32-S2-Saola-1` connected via UART.
- `GPIO2` and `GPIO3` are I2C pins.
- `GPIO9` and `GPIO10` are connected.
- `GPIO5` and `GPIO6` are connected.
- Probe: `ESP-Prog` connected with the [following connections][connection_s2]
- RPi: Raspbian 12 configured with the following [setup]
- ESP32-S3 (`esp32s3-usb`):
Expand Down
7 changes: 4 additions & 3 deletions hil-test/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,12 @@ macro_rules! i2c_pins {
macro_rules! common_test_pins {
($io:expr) => {{
cfg_if::cfg_if! {
if #[cfg(not(any(esp32s2, esp32s3)))] {
($io.pins.gpio2, $io.pins.gpio3)
} else if #[cfg(any(esp32s2, esp32s3))] {
if #[cfg(any(esp32s2, esp32s3))] {
($io.pins.gpio9, $io.pins.gpio10)
}
else {
($io.pins.gpio2, $io.pins.gpio3)
}
}
}};
}

0 comments on commit 5b56aa7

Please sign in to comment.