Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 7.x #28

Merged
merged 1 commit into from
Oct 18, 2022
Merged

feat: support ESLint 7.x #28

merged 1 commit into from
Oct 18, 2022

Conversation

@MichaelDeBoey MichaelDeBoey requested a review from a team October 17, 2022 19:17
@MichaelDeBoey MichaelDeBoey self-assigned this Oct 17, 2022
@MichaelDeBoey MichaelDeBoey added the enhancement New feature or request label Oct 17, 2022
@ota-meshi
Copy link
Member

We should probably merge from the alpha branch into this PR.

package.json Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey merged commit 6a7a1f1 into main Oct 18, 2022
@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch October 18, 2022 14:23
@github-actions
Copy link

🎉 This PR is included in version 15.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -27,6 +27,7 @@ module.exports = {
"consistent-return": "error",
curly: "error",
"default-case": "error",
"default-case-last": "error",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eslint-community/mysticatea-eslint-plugin Adding these as 'error' was a breaking change, no?

We also support v6 with this plugin & people using v6 won't have these rules so ESLint will throw I think 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
2 participants