Upgrade: eslint and other deps #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
commented
Apr 7, 2020
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| const rule = require('../../../lib/rules/no-deprecated-report-api'); | |||
| const RuleTester = require('eslint').RuleTester; | |||
| const ERROR = [{ message: 'Use the new-style context.report() API.', type: 'CallExpression' }]; | |||
| const ERROR = { message: 'Use the new-style context.report() API.', type: 'Identifier' }; | |||
There was a problem hiding this comment.
this was caught by the new eslint v7. 🎉
aladdin-add
commented
Apr 7, 2020
.eslintrc.yml
Outdated
| - error | ||
| - arrays: always-multiline | ||
| objects: always-multiline | ||
| functions: never # disallow trailing commases in function(es2017) |
There was a problem hiding this comment.
you want to change your eslint-config? :)
aladdin-add
force-pushed
the
upgrade/eslint
branch
from
0a1a86d
to
b7173bf
Compare
not-an-aardvark
approved these changes
Apr 8, 2020
This was referenced May 8, 2020
Closed
This was referenced May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.