Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix decoding account from E3 encoded storage #2254

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Aug 21, 2024

This PR fixes the unit test failures happening on master branch after merging #2251

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.80%. Comparing base (9aace13) to head (5c50701).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   52.82%   52.80%   -0.03%     
==========================================
  Files         719      719              
  Lines       49221    49224       +3     
  Branches     7499     7500       +1     
==========================================
- Hits        26001    25992       -9     
- Misses      20926    20936      +10     
- Partials     2294     2296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Aug 21, 2024
@canepat canepat marked this pull request as ready for review August 21, 2024 14:56
@canepat canepat merged commit d801290 into master Aug 21, 2024
16 checks passed
@canepat canepat deleted the ci/fix_account_from_encoded_storage_v3 branch August 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants