core: decode account from E3 encoded storage #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
approved these changes
Aug 21, 2024
Comment on lines
+157
to
+169
| for (int i{0}; i < 4; ++i) { | ||
| uint8_t len = encoded_payload[pos++]; | ||
| if (len == 0) { | ||
| if (encoded_payload.length() == pos && i < 3) { | ||
| return tl::unexpected{DecodingError::kUnexpectedLength}; | ||
| } | ||
| continue; | ||
| } | ||
| if (encoded_payload.length() < pos + len) { | ||
| return tl::unexpected{DecodingError::kInputTooShort}; | ||
| } | ||
| const auto encoded_value{encoded_payload.substr(pos, len)}; | ||
| switch (i) { |
There was a problem hiding this comment.
this loop with a switch is a smart hack to structure the code
it took me a while to figure it out
a more basic way would be to extract this preambule into a helper function or a local lambda,
and then call it before each decoding attempt
There was a problem hiding this comment.
I did it this way for similarity with the code already present in Account::from_encoded_storage
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.