Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: fix Windows build after PR 2201 #2216

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Aug 8, 2024

This PR fix Windows build after #2201.

The error was misleading because MSVC 19.40 complains about Compiler Error C2440, which seems strange at first, but in the end it's due to the missing conversion operator from std::filesystem::path to std::string.

Extras

  • remove unused include
  • simplify some expressions as suggested by CLion

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Aug 8, 2024
@canepat canepat requested a review from JacekGlen August 8, 2024 14:39
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.51%. Comparing base (8ef63c7) to head (7753506).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   53.50%   53.51%           
=======================================
  Files         689      689           
  Lines       48046    48046           
  Branches     7292     7292           
=======================================
+ Hits        25708    25710    +2     
+ Misses      20087    20084    -3     
- Partials     2251     2252    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@canepat canepat marked this pull request as ready for review August 8, 2024 15:56
@canepat canepat merged commit 451469e into master Aug 8, 2024
16 checks passed
@canepat canepat deleted the ci/fix_windows_build_after_2201 branch August 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant