Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

capi: fork validator #2201

Merged
merged 15 commits into from
Aug 7, 2024
Merged

capi: fork validator #2201

merged 15 commits into from
Aug 7, 2024

Conversation

JacekGlen
Copy link
Member

@JacekGlen JacekGlen commented Aug 2, 2024 •
edited by canepat
Loading

Closes #2058

Exposes Fork Validator endpoints to CAPI:

  • verify chain
  • fork choice update

Linked PR: erigontech/silkworm-go#10

@JacekGlen JacekGlen requested a review from canepat August 2, 2024 13:06
@JacekGlen JacekGlen mentioned this pull request Aug 2, 2024
Merged
@canepat canepat mentioned this pull request Aug 2, 2024
Closed
7 tasks
canepat
canepat requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@canepat canepat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, you should integrate and test block execution at the chain tip within Erigon2, so you don't want to update mdbx-go version now.

@canepat canepat added erigon2 backlog Erigon2 feature still missing execution at tip Block execution at the chain tip labels Aug 6, 2024
@JacekGlen JacekGlen marked this pull request as draft August 7, 2024 08:18
@JacekGlen JacekGlen marked this pull request as ready for review August 7, 2024 14:30
@canepat canepat added the c api The C API exposed for Erigon label Aug 7, 2024
@canepat canepat self-requested a review August 7, 2024 14:35
canepat
canepat requested changes Aug 7, 2024
View reviewed changes
silkworm/capi/silkworm.h Outdated Show resolved Hide resolved
silkworm/capi/silkworm.h Show resolved Hide resolved
silkworm/capi/silkworm_test.cpp Outdated Show resolved Hide resolved
silkworm/capi/silkworm_test.cpp Outdated Show resolved Hide resolved
@JacekGlen JacekGlen requested a review from canepat August 7, 2024 20:46
@canepat canepat merged commit 8ef63c7 into master Aug 7, 2024
4 checks passed
@canepat canepat deleted the capi-fork-validator branch August 7, 2024 22:37
@canepat canepat mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canepat canepat canepat approved these changes

Assignees
No one assigned
Labels
c api The C API exposed for Erigon erigon2 backlog Erigon2 feature still missing execution at tip Block execution at the chain tip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exposing C API for tip block execution
3 participants
@JacekGlen @canepat @web-flow