Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eliminate business logic from IndexRange #13459

Merged
merged 4 commits into from
Jan 28, 2025
Merged

eliminate business logic from IndexRange #13459

merged 4 commits into from
Jan 28, 2025
+60 −60

Conversation

sudeepdino008
Copy link
Member

@sudeepdino008 sudeepdino008 commented Jan 16, 2025 •
edited
Loading

  • respond to this comment
  • benchmark results (pr here)
main
BenchmarkAggregator_BeginFilesRo/begin_files_ro-16 1490890 850.0 ns/op 3280 B/op 22 allocs/op


aggr12 branch
BenchmarkAggregator_BeginFilesRo/begin_files_ro-16 1688707 712.3 ns/op 3216 B/op 21 allocs/op

@sudeepdino008 sudeepdino008 mentioned this pull request Jan 16, 2025
Closed
awskii
awskii previously requested changes Jan 16, 2025
View reviewed changes
erigon-lib/state/aggregator2.go Outdated Show resolved Hide resolved
erigon-lib/state/aggregator.go Show resolved Hide resolved
Base automatically changed from aggr11 to main January 28, 2025 10:02
@sudeepdino008 sudeepdino008 dismissed awskii’s stale review January 28, 2025 15:20

discussed offline

@sudeepdino008 sudeepdino008 merged commit c8d89ee into main Jan 28, 2025
13 checks passed
@sudeepdino008 sudeepdino008 deleted the aggr12 branch January 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

@awskii awskii awskii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta3
Development

Successfully merging this pull request may close these issues.
3 participants
@sudeepdino008 @awskii @AskAlexSharov