Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take replaceKeysInValues out of agg #13444

Merged
merged 1 commit into from
Jan 16, 2025
Merged

take replaceKeysInValues out of agg #13444

merged 1 commit into from
Jan 16, 2025

Conversation

sudeepdino008
Copy link
Member

No description provided.

IndexList: AccessorHashMap,
Compression: seg.CompressKeys,
CompressCfg: DomainCompressCfg,
IndexList: AccessorHashMap,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename “IndexList” to “AccessorList”

@AskAlexSharov AskAlexSharov merged commit 009d5da into main Jan 16, 2025
14 checks passed
@AskAlexSharov AskAlexSharov deleted the aggr10 branch January 16, 2025 04:16
sudeepdino008 added a commit that referenced this pull request Jan 28, 2025
- respond to
[this](#13444 (comment))
comment
- benchmark results (pr
[here](https://github.com/erigontech/erigon/pull/13602/files))
```
main
BenchmarkAggregator_BeginFilesRo/begin_files_ro-16 1490890 850.0 ns/op 3280 B/op 22 allocs/op


aggr12 branch
BenchmarkAggregator_BeginFilesRo/begin_files_ro-16 1688707 712.3 ns/op 3216 B/op 21 allocs/op
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants