Fix path matching issue with usemin on Windows #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
added a commit
that referenced
this pull request
Feb 16, 2014
Fix path matching issue with usemin on Windows
|
Thanks! |
|
Wonderful! Tested on a Window 8.1 Pro machine and on Heroku successfully! |
|
::whew:: I'm glad. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are working with both Windows and Linux, a common solution must be used for how path are compared with usemin:
It would be better instead to normalize the path specified in the build:js section and compare with the file system result.
Note that tests were not updated because they will not run on Windows (I attempted to fix them quickly but I don't have more time to put on this at the moment)