Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slash escaping for usemin target on Windows #72

Closed
wants to merge 1 commit into from

Conversation

jbalboni
Copy link

Hi,

This is a fix for the problem in issue #70. The workaround of specifying \ instead of / in the usemin target path works, but we run our grunt build process on Mac and Windows machines, so it would be nice to have one target that works for both platforms. Plus, it looks like the grunt/usemin convention is to use forward slashes everywhere.

I wasn't sure how to write a test for this, since the tests don't seem to work on Windows (on my machine, anyway).

Thanks!

@christianrondeau
Copy link
Contributor

Another similar solution here: #80 (the main difference is relying on node.js "path" instead of checking for the OS, both are valid options)

@ericclemmons
Copy link
Owner

@christianrondeau Let me know if this is still necessary, since v0.5.2 was just released via #80!

@christianrondeau
Copy link
Contributor

Both are addressing the same issue, so I don't believe this pull request to still be useful (if @jbalboni agrees with me)

@jbalboni
Copy link
Author

Yep, I agree. Thanks @christianrondeau and @ericclemmons.

@jbalboni jbalboni closed this Feb 17, 2014
@ericclemmons
Copy link
Owner

YAY TEAMWORK! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants