Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Synchronize with ergebnis/php-library-template #130

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

localheinz
Copy link
Member

This PR

@localheinz localheinz self-assigned this Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #130   +/-   ##
=========================================
  Coverage     98.55%   98.55%           
  Complexity       48       48           
=========================================
  Files             6        6           
  Lines           138      138           
=========================================
  Hits            136      136           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a763926...ab96745. Read the comment docs.

@@ -32,7 +32,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use the @v1 tag. shivammathur takes care of re-tagging the @v1 to whatever new release he publishes

see https://github.com/shivammathur/setup-php/releases/tag/v1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed, yes, but to be honest, I'm not sure this is the best idea (retagging).

I think it would be great if GitHub came around to properly resolving versions!

Also see https://github.community/t5/GitHub-Actions/Referencing-major-version-of-GitHub-action-only-fails-to/m-p/40562#M4280.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh my. seems they did reinvent the wheel instead of learning from package managers doing this kind of stuff for years :-/

@localheinz localheinz merged commit b3ffed1 into master Jan 22, 2020
@localheinz localheinz deleted the feature/synchronize branch January 22, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants