Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Synchronize with ergebnis/php-library-template #130

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Enhancement: Synchronize with ergebnis/php-library-template #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use the @v1 tag. shivammathur takes care of re-tagging the @v1 to whatever new release he publishes

see https://github.com/shivammathur/setup-php/releases/tag/v1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed, yes, but to be honest, I'm not sure this is the best idea (retagging).

I think it would be great if GitHub came around to properly resolving versions!

Also see https://github.community/t5/GitHub-Actions/Referencing-major-version-of-GitHub-action-only-fails-to/m-p/40562#M4280.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh my. seems they did reinvent the wheel instead of learning from package managers doing this kind of stuff for years :-/

with:
coverage: "none"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "none"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "none"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "none"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "xdebug"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "xdebug"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down Expand Up @@ -334,8 +334,8 @@ jobs:
- name: "Run mutation tests with Xdebug and infection/infection"
run: "vendor/bin/infection --ignore-msi-with-no-mutations --min-covered-msi=${{ env.MIN_COVERED_MSI }} --min-msi=${{ env.MIN_MSI }}"

approve:
name: "Approve"
review:
name: "Review"

runs-on: "ubuntu-latest"

Expand All @@ -353,3 +353,9 @@ jobs:
if: "(github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]') && github.event_name == 'pull_request' && startsWith(github.event.pull_request.title, 'Build(deps-dev)')"
with:
github-token: "${{ secrets.ERGEBNIS_BOT_TOKEN }}"

- name: "Approve pull requests created by @ergebnis-bot that update the license year"
uses: "hmarr/auto-approve-action@v2.0.0"
if: "github.actor == 'ergebnis-bot' && github.event_name == 'pull_request' && github.event.pull_request.title == 'Enhancement: Update license year'"
with:
github-token: "${{ secrets.ERGEBNIS_BOT_TOKEN }}"
2 changes: 1 addition & 1 deletion .github/workflows/license.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
uses: "actions/checkout@v2.0.0"

- name: "Install PHP with extensions"
uses: "shivammathur/setup-php@1.7.3"
uses: "shivammathur/setup-php@1.7.4"
with:
coverage: "none"
extensions: "${{ env.REQUIRED_PHP_EXTENSIONS }}"
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
days-before-close: 5
days-before-stale: 60
repo-token: "${{ secrets.ERGEBNIS_BOT_TOKEN }}"
stale-issue-label: 'stale'
stale-issue-label: "stale"
stale-issue-message: >
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
Since this issue has not had any activity within the last sixty days, I have marked it as stale.

I will close it if no further activity occurs within the next five days.
stale-pr-label: "stale"
stale-pr-message: >
This PR has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
Since this pull request has not had any activity within the last sixty days, I have marked it as stale.

I will close it if no further activity occurs within the next five days.
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ Please have a look at [`CODE_OF_CONDUCT.md`](https://github.com/ergebnis/.github

## License

This package is licensed using the [MIT License](LICENSE.md).
This package is licensed using the MIT License.

Please have a look at [`LICENSE.md`](LICENSE.md).

## Credits

Expand Down