Clean up equivalent polynomials implementation and cutfem method #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structor (equal to 0.0). When I switched memBase to Profiling.memLast to get rid of the NameError, it seemed to run fine. I don't know what the significance of memBase is, but it wasn't being used anywhere outside of log statements from what I could tell.
* rits-true option for linear solver convergence (exit on r or its) * safeguard against degenerate quad cut case (cut hits two vertices) * commented out hack to pin pressure dof for pure neumann problem
memBase from NumericalSolution.py is Profiling.memLast inside the con…
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
=======================================
Coverage 52.81% 52.82%
=======================================
Files 531 531
Lines 109772 109802 +30
=======================================
+ Hits 57975 58001 +26
- Misses 51797 51801 +4
Continue to review full report at Codecov.
|
ejtovar
reviewed
Jan 16, 2021
| @@ -1440,11 +1440,13 @@ def apply(self,A,x,y): | |||
| zero_array = numpy.zeros(len(self.known_dof_is.getIndices())) | |||
|
|
|||
| tmp2.setValues(self.known_dof_is.getIndices(),zero_array) | |||
| tmp2.assemblyBegin() | |||
There was a problem hiding this comment.
What does the assemblyBegin() do? Was this a typo that it wasn't there before?
ejtovar
approved these changes
Jan 16, 2021
cekees
commented
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mandatory Checklist
Please ensure that the following criteria are met:
As a general rule of thumb, try to follow PEP8 guidelines.
Description