Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memBase from NumericalSolution.py is Profiling.memLast inside the con… #1

Merged
merged 2 commits into from
Jan 12, 2021
Merged

memBase from NumericalSolution.py is Profiling.memLast inside the con… #1

merged 2 commits into from
Jan 12, 2021

Conversation

jhcollins
Copy link

…structor (equal to 0.0). When I switched memBase to Profiling.memLast to get rid of the NameError, it seemed to run fine. I don't know what the significance of memBase is, but it wasn't being used anywhere outside of log statements from what I could tell.

Mandatory Checklist

Please ensure that the following criteria are met:

  • Title of pull request describes the changes/features
  • Request at least 2 reviewers
  • If new files are being added, the files are no larger than 100kB. Post the file sizes.
  • Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
  • New features have appropriate documentation strings (readable by sphinx)
  • Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.

Description

…structor (equal to 0.0). When I switched memBase to Profiling.memLast to get rid of the NameError, it seemed to run fine. I don't know what the significance of memBase is, but it wasn't being used anywhere outside of log statements from what I could tell.
@jhcollins
Copy link
Author

@cekees I'm guessing it automatically notifies you without me assigning you as a reviewer on your own fork.

@cekees cekees merged commit 75ece06 into cekees:eqp_final Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants