Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate ecl2df integration, add res2df integration #250

Merged
merged 2 commits into from
Apr 26, 2024
Merged

deprecate ecl2df integration, add res2df integration #250

merged 2 commits into from
Apr 26, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Apr 24, 2024 •
edited
Loading

closes #243

@eivindjahren eivindjahren changed the title Resdata deprecate ecl2df integration, add res2df integration Apr 24, 2024
@eivindjahren eivindjahren requested review from asnyv and larsevj April 24, 2024 07:35
larsevj
larsevj approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@larsevj larsevj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the function get_eclsum in realization.py does not need a rename?

Otherwise, LGMT 👍

@eivindjahren eivindjahren merged commit af1bc17 into equinor:master Apr 26, 2024
6 checks passed
@eivindjahren eivindjahren deleted the resdata branch April 26, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsevj larsevj larsevj approved these changes

@asnyv asnyv Awaiting requested review from asnyv

Assignees
No one assigned
Labels
None yet
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecl2df has been renamed to res2df
3 participants
@eivindjahren @larsevj @asnyv