Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecl2df has been renamed to res2df #243

Closed
eivindjahren opened this issue Jan 29, 2024 · 2 comments · Fixed by #250
Closed

ecl2df has been renamed to res2df #243

eivindjahren opened this issue Jan 29, 2024 · 2 comments · Fixed by #250

Comments

@eivindjahren
Copy link
Contributor

The import

fmu-ensemble/src/fmu/ensemble/realization.py

Line 37 in ab3f4d7

import ecl2df
should be changed to res2df and ecl2df.EclFiles is now res2df.ResFiles.
@asnyv asnyv mentioned this issue Jan 30, 2024
Closed
@eivindjahren
Copy link
Contributor Author

@asnyv any update on this?

@asnyv
Copy link
Collaborator

asnyv commented Mar 13, 2024

@asnyv any update on this?

except that I had completely forgotten about it: Not until now 🤷‍♂️

Updated the PR now, tests are green.
But I must admit it is the "lazy version": search, replace and hope that tests catches any issue.
Have not gone through every single file manually.

@eivindjahren eivindjahren mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eivindjahren @asnyv