Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.13.0 #645

Merged
merged 108 commits into from
May 29, 2024
Merged

Release v1.13.0 #645

merged 108 commits into from
May 29, 2024

Conversation

pattonwebz
Copy link
Member

@pattonwebz pattonwebz commented May 28, 2024 •
edited
Loading

Steve Jones (1):

  • Rule Viewable

William Patton (12):

  • Add error for zoom disabled via viewport meta tag
  • Convert text_justified rule to a JS rule
  • Enable the blinks and marquee axe-core rules to power the text_blinking_scrolling rule
  • Convert the text_small rule to JS check
  • Add a rule and check for empty paragraphs
  • Check possible_heading rule with computedStyles
  • Integration branch for all recent rule changes
  • Check for typeof 'number' instead of instanceof Number
  • Update the zooming and scaling user facing title and the help link
  • Remove the dry run flag in the deploy-on-release-to-dot-org.yml workflow
  • Don't flag missing iframe title if it's display: none and visibility: hidden

pattonwebz added 30 commits April 25, 2024 18:09
@pattonwebz
Add a rule and check for empty paragraphs
6a52823
@pattonwebz
Run the check for empty paragraphs in JS page scanner
c17e9c0
@pattonwebz
Use the id direct from the import to avoid needing to write a string …
fc819ad 
…in 2 places
@pattonwebz
Add the empty paragraph rule to rules array
d533bab
@pattonwebz
Add a filter to make empty paragraph html unique
7b75bea
@pattonwebz
Add error for zoom disabled via viewport meta tag
abf8b96 
This will flag an error if user-scalable is set to 'no' or if the maximum-scale is lower than 2
@pattonwebz
Merge branch 'develop' into william/589/add-error-if-zooming-is-disab…
2aba5de 
…led-view-viewport-meta-tag
@pattonwebz
Make empty paragraph a warning
ca54ed4
@pattonwebz
Fix filter to use method from inside the class
e1a5d0b
@pattonwebz
Use singular form for title and update the summary text
e0ac1c5 
Also make the link not hit a 404 or other unexpected page, point just to the root
@pattonwebz
Add a rule and check file for detection paragraphs that are possible …
437f45d 
…headings
@pattonwebz
Include the possible_heading rule in the page scanner
8187628
@pattonwebz
Make the possible_heading rule use the js ruleset
0d5ade2
@pattonwebz
Remove the possible_heading.php file as it is replaced by JS
e9bb544
@pattonwebz
Use 'empty_paragraph' as the slug for new rule
88e3a61
@pattonwebz
Use 'empty_paragraph_tag' as the slug for new rule
102cbe4
@pattonwebz
Add best practices tag to new empty paragraphs rule
93856d9
@pattonwebz
Merge pull request #627 from equalizedigital/release/1.12.0
e5f5332 
Release/1.12.0 backport
@pattonwebz
Update paragraph_not_empty check to pass elements with no text conten…
c0e9576 
…t if they have child elements.
@pattonwebz
Simplify the final return in paragraph_not_empty
1bcda56
@pattonwebz
Simplify the final return in paragraph_not_empty
2aee264
@pattonwebz
Improve comment in paragraph-styled-as-header.js check
ddb578f
@pattonwebz
Add a helpers file with a fontSizeInPxxx function
45f435c
@pattonwebz
Use new fontSizeInPx helper
3580bf7
@pattonwebz
Use < 16px in first return so that everything after it is 16px or more.
b02dc50
@pattonwebz
Add a helpers file with a fontSizeInPxxx function
552f2e6
@pattonwebz
Add a check for small text of 10px or less
06ccfce
@pattonwebz
Add rule that checks for small text
33420b2
@pattonwebz
Swap the text_small rule to the JS ruleset
2ce6562
@pattonwebz
Remove the text_small.php rule file
0d6d7a0
pattonwebz and others added 19 commits May 24, 2024 19:51
@pattonwebz
Handle potential NaN values by checking for instance of Number
913aeca
@pattonwebz
Merge remote-tracking branch 'origin/william/612/move-possible_headin…
01bfc89 
…g-rule-to-JS-check' into william/612/move-possible_heading-rule-to-JS-check
@pattonwebz
Merge branch 'develop' into william/612/move-possible_heading-rule-to…
97ea323 
…-JS-check
@pattonwebz
Merge pull request #622 from equalizedigital/william/612/move-possibl…
c7b2130 
…e_heading-rule-to-JS-check

Check possible_heading rule with computedStyles
@pattonwebz
Merge branch 'develop' into release/alpha/1.13.0
18ecf1a
@pattonwebz
Fix extra space before opening bracket
7f9c3b8
@SteveJonesDev
Merge pull request #640 from equalizedigital/steve/no-issue/add-rule-…
a04536f 
…viewable-structure
@pattonwebz
Merge pull request #638 from equalizedigital/release/alpha/1.13.0
50e32d5 
Integration branch for all recent rule changes
@pattonwebz
Don't flag missing iframe title if it's display: none and visibility:…
6322ea8 
… hidden

Google tag manager iframe should no longer create noise with this change
@pattonwebz
Check for typeof 'number' instead of instanceof Number
7f96573
@pattonwebz
Merge pull request #642 from equalizedigital/william/no-issue/fix-fon…
19f646c 
…tsize-helper-checking-number-object-and-not-primitive

Check for `typeof` 'number' instead of `instanceof Number`
@pattonwebz
Merge branch 'develop' into william/184/exclude-iframes-from-empty-ti…
5e4335c 
…tle-check-if-displaynone-and-visibilityhidden
@pattonwebz
Update the zooming and scaling user facing title and the help link
47bb153
@pattonwebz
Merge pull request #643 from equalizedigital/william/69/zooming-and-s…
b212b32 
…caling-text-tweak

Update the zooming and scaling user facing title and the help link
@pattonwebz
Remove the dry run flag in the deploy-on-release-to-dot-org.yml workflow
99ebe93
@pattonwebz
Merge pull request #644 from equalizedigital/william/no-issue/remove-…
995d953 
…the-dryrun-flag-from-deploy-to-dot-org-release

Remove the dry run flag in the deploy-on-release-to-dot-org.yml workflow
@pattonwebz
Merge pull request #641 from equalizedigital/william/184/exclude-ifra…
2ad07b0 
…mes-from-empty-title-check-if-displaynone-and-visibilityhidden

Don't flag missing iframe title if it's display: none and visibility: hidden
@pattonwebz
Bump version 1.12.0 -> 1.13.0
5c09e00
@pattonwebz
Add changelog for 1.13.0
4c0f166
@pattonwebz pattonwebz requested a review from SteveJonesDev May 28, 2024 14:24
pattonwebz added 3 commits May 28, 2024 20:05
@pattonwebz
Merge pull request #647 from equalizedigital/william/646/sync-summari…
880d16e 
…es-on-rules-from-sheet

Sync summaries on rules from sheet
@pattonwebz
Correct iframe_missing_title summary
4215ac5
@pattonwebz
Merge pull request #648 from equalizedigital/william/628/correct_ifra…
ca4e60c 
…me_missing_title_summary

Correct iframe_missing_title summary
@SteveJonesDev SteveJonesDev self-requested a review May 29, 2024 13:23
@pattonwebz pattonwebz merged commit 55a2aef into main May 29, 2024
23 checks passed
@pattonwebz pattonwebz deleted the release/1.13.0 branch June 26, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveJonesDev SteveJonesDev SteveJonesDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattonwebz @SteveJonesDev