Don't flag missing iframe title if it's display: none and visibility: hidden #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hidden Google tag manager iframe should no longer create noise with this change
…tle-check-if-displaynone-and-visibilityhidden
SteveJonesDev
approved these changes
May 28, 2024
pattonwebz
deleted the
william/184/exclude-iframes-from-empty-title-check-if-displaynone-and-visibilityhidden
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for
display:noneandvisibility: hiddenbefore determining if it should create an issue for an iframe. Google tag manager iframe should no longer create noise with this change since it has both.Closes: #184