Enable the blinks and marquee axe-core rules to power the text_blinking_scrolling rule #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… definition The combines holds the 2 axe rule ids that are run in the scanner that are both grouped under the one rule ID in the reporting
…Axe-Core run JavaScript equivalent
SteveJonesDev
approved these changes
May 23, 2024
pattonwebz
deleted the
william/636/convert-text_blinking_scrolling-to-js-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the 'blink' and 'marquee' rules from axe-core and combines the results of those checks under the
text_blinking_scrollingreporting rule.Using axe-core rules for blink means no longer parsing the CSS and checking for
text-decoration: blink;. Any JS side check for it will be unreliable because most common browsers strip it out as it was deprecated long ago and is not supported by the major browsers at this point.