Merge pull request #637 from equalizedigital/william/636/convert-text…

…_blinking_scrolling-to-js-check

Enable the blinks and marquee axe-core rules to power the text_blinking_scrolling rule

includes/classes/class-rest-api.php

@@ -199,6 +199,7 @@ public function set_post_scan_results( $request ) {
 			if ( array_key_exists( 'ruleset', $rule ) && 'js' === $rule['ruleset'] ) {
 				$js_rule_ids[] = $rule['slug'];
 
+				// Some rules can be a grouping of other checks with different ids. This tracks those combined check IDs for later mapping.
 				if ( array_key_exists( 'combines', $rule ) && ! empty( $rule['combines'] ) ) {
 					foreach ( $rule['combines'] as $combine_rule_id ) {
 						$combined_rule_ids[ $combine_rule_id ] = $rule['slug'];
@@ -231,6 +232,7 @@ public function set_post_scan_results( $request ) {
 				foreach ( $violations as $violation ) {
 					$rule_id = $violation['ruleId'];
 
+					// If this rule is a combined rule then map it to the actual reporting rule ID.
 					$actual_rule_id = array_key_exists( $rule_id, $combined_rule_ids ) ? $combined_rule_ids[ $rule_id ] : $rule_id;
 
 					if ( in_array( $actual_rule_id, $js_rule_ids, true ) ) {

includes/rules.php

@@ -330,6 +330,8 @@
 			'<code>&lt;marquee&gt;</code>',
 			'<code>text-decoration: blink</code>'
 		),
+		'ruleset'   => 'js',
+		'combines'  => [ 'blink', 'marquee' ],
 	],
 	[
 		'title'     => esc_html__( 'Insufficient Color Contrast', 'accessibility-checker' ),

src/pageScanner/index.js

@@ -60,6 +60,8 @@ const scan = async (
 				values: [
 					'color_contrast_failure',
 					'underlined_text',
+					'blink',
+					'marquee',
 					'meta-viewport',
 					textJustified.id,
 				],