Fix URL encoding for space characters #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gplusplus314
force-pushed
the
fix_urlEncoding
branch
from
342dc9d
to
3c12c54
Compare
flaviosakakibara
pushed a commit
to flaviosakakibara/obsidian.nvim
that referenced
this pull request
Sep 5, 2023
* fix: don't check third party for Lua LSP Co-authored-by: Sean <44933921+seantwie03@users.noreply.github.com> Co-authored-by: TJ DeVries <devries.timothyj@gmail.com> Co-authored-by: Sean <44933921+seantwie03@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this one while using #56 , but this should improve general compatibility for anything that needs URI encoding. Turns out, encoding URIs in Lua is kind of a pain. Didn't know that. But this seems to do the trick for all the edge cases I personally have.
TLDR here is that
%20is always a safe encoding for a space character, regardless of where it is in the raw URL string, but+is interpreted as a literal if it's in a query param value.