Add line-navigation to :ObsidianOpen (AdvancedURI) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm very unsure about the way I propagated the |
gplusplus314
force-pushed
the
advancedUriSupport
branch
3 times, most recently
from
a1cedc7
to
5e24656
Compare
epwalsh
reviewed
Nov 25, 2022
lua/obsidian/command.lua
Outdated
Comment on lines
9
to
18
| local opts = { | ||
| use_advanced_uri = nil, | ||
| } | ||
|
|
||
| --- Inject init/setup dependencies here (internal use) | ||
| --- | ||
| ---@param use_advanced_uri boolean|? | ||
| command.setup = function(use_advanced_uri) | ||
| opts.use_advanced_uri = use_advanced_uri | ||
| end |
There was a problem hiding this comment.
I don't think you need all this because you can just access client.opts.use_advanced_uri directly.
There was a problem hiding this comment.
I had a feeling I was doing something not quite right. Give me a sec.
This PR adds a thin integration with the Obsidian Advanced URI plugin, allowing :ObsidianOpen to automatically scroll the Obsidian editor to the same line as NeoVim's. See: [Obsidian Advanced URI](https://github.com/Vinzent03/obsidian-advanced-uri)
gplusplus314
force-pushed
the
advancedUriSupport
branch
from
5e24656
to
be3effe
Compare
…advancedUriSupport
gplusplus314
commented
Nov 25, 2022
| @@ -97,16 +97,24 @@ command.open = function(client, data) | |||
|
|
|||
| local encoded_vault = util.urlencode(vault_name) | |||
| local encoded_path = util.urlencode(tostring(path)) | |||
|
|
|||
| local uri | |||
| if client.opts.use_advanced_uri then | |||
There was a problem hiding this comment.
Here we go. Thanks for pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a thin integration with the Obsidian Advanced URI plugin, allowing :ObsidianOpen to automatically scroll the Obsidian editor to the same line as NeoVim's.
See: Obsidian Advanced URI
Note: scrolling in the Reading viewmode does not currently work (see this issue). The Obsidian editor will scroll correctly when it's in edit-mode.