Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backmerge: #4192 - Export to SVG/PNG ignores "Show hydrogen labels" option #4317

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Backmerge: #4192 - Export to SVG/PNG ignores "Show hydrogen labels" option #4317

merged 2 commits into from
Mar 22, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Mar 22, 2024 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91 rrodionov91 linked an issue Mar 22, 2024 that may be closed by this pull request
Export to SVG/PNG ignores "Show hydrogen labels" option #4192
Closed
@rrodionov91 rrodionov91 changed the title #4192 - Export to SVG/PNG ignores "Show hydrogen labels" option Backmerge: #4192 - Export to SVG/PNG ignores "Show hydrogen labels" option Mar 22, 2024
@AlexeyGirin AlexeyGirin self-requested a review March 22, 2024 10:25
AlexeyGirin
AlexeyGirin approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rrodionov91 rrodionov91 merged commit 4e97c7b into master Mar 22, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4192-export-svg-png-ignores-params-backmerge branch March 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyGirin AlexeyGirin AlexeyGirin approved these changes

@ilya-asiyuk-epam ilya-asiyuk-epam Awaiting requested review from ilya-asiyuk-epam

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export to SVG/PNG ignores "Show hydrogen labels" option
2 participants
@rrodionov91 @AlexeyGirin