Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to SVG/PNG ignores "Show hydrogen labels" option #4192

Closed
AlexeyGirin opened this issue Mar 4, 2024 · 1 comment · Fixed by #4306 or #4317
Closed

Export to SVG/PNG ignores "Show hydrogen labels" option #4192

AlexeyGirin opened this issue Mar 4, 2024 · 1 comment · Fixed by #4306 or #4317
Assignees
@rrodionov91
Labels
bug Priority: High
Milestone
Ketcher 2.20.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Mar 4, 2024 •
edited
Loading

Describe the bug
Export to SVG/PNG ignores "Show hydrogen labels" option

Steps to Reproduce

  1. Put on the canvas following SMILE: C1CCCN(C)C1
  2. Go to Settings->Atoms and set "Show hydrogen labels" option to Off
  3. Press Save button (Ctrl+S) and select SVG Document at "File format" (same problem for PNG Image option)
    image

Actual behavior
Export to SVG ignores "Show hydrogen labels" option and keeps hydrogens in place
image

Expected behavior
No hydrogens
image

Environment details (please complete the following information):

  • Indigo Toolkit Version 1.18.0-rc.9.0-gc7efb4e71-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.18.0-rc9 Build at 2024-02-27; 16:16:47
  • Chrome Version 122.0.6261.70 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.19.0-rc.2 milestone Mar 4, 2024
@AlexeyGirin AlexeyGirin changed the title Export to SVG ignores "Show hydrogen labels" option Export to SVG/PNG ignores "Show hydrogen labels" option Mar 4, 2024
@rrodionov91 rrodionov91 self-assigned this Mar 21, 2024
rrodionov91 added a commit that referenced this issue Mar 21, 2024
@rrodionov91
#4192 - Export to SVG/PNG ignores "Show hydrogen labels" option
24a8a1e
@rrodionov91 rrodionov91 linked a pull request Mar 21, 2024 that will close this issue
#4192 - Export to SVG/PNG ignores "Show hydrogen labels" option #4306
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Mar 22, 2024
@rrodionov91
#4192 - Export to SVG/PNG ignores "Show hydrogen labels" option (#4306)
e9cd78c
rrodionov91 added a commit that referenced this issue Mar 22, 2024
@rrodionov91
#4192 - Export to SVG/PNG ignores "Show hydrogen labels" option
8ea7b77
@rrodionov91 rrodionov91 linked a pull request Mar 22, 2024 that will close this issue
Backmerge: #4192 - Export to SVG/PNG ignores "Show hydrogen labels" option #4317
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Mar 22, 2024
@rrodionov91
Backmerge: #4192 - Export to SVG/PNG ignores "Show hydrogen labels" o…
4e97c7b 
…ption (#4317)
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Indigo Toolkit Version 1.19.0-rc.2.0-g6c0e3fecf-x86_64-linux-gnu-11.2.1
  • Ketcher Version 2.20.0-rc2 Build at 2024-03-27; 08:30:51
  • Chrome Version 122.0.6261.70 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.20.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin