#2060: Don't break the selection if the user's cursor goes beyond the canvas #2071
Conversation
There was a problem hiding this comment.
I've checked this PR locally and found that tools, which have multiple options (for example, selections and bonds) don't work from first time, if click on left panel.
You need to perform at least, two clicks in order to open, for example, panel for selection tool:
Could you, please, have a look?
St-Permiakov
force-pushed
the
#2060-dont-break-the-selection-if-the-users-cursor-goes-beyond-the-canvas
branch
from
eaa2bff
to
35c91bb
Compare
St-Permiakov
force-pushed
the
#2060-dont-break-the-selection-if-the-users-cursor-goes-beyond-the-canvas
branch
from
35c91bb
to
838bf08
Compare
Nitvex
deleted the
#2060-dont-break-the-selection-if-the-users-cursor-goes-beyond-the-canvas
branch
| { target: clientArea, eventName: 'mousedown' }, | ||
| { target: document, eventName: 'mousemove' }, | ||
| { target: document, eventName: 'mouseup' }, | ||
| { target: document, eventName: 'mouseleave' }, |
There was a problem hiding this comment.
Hi 😃 seems it causes a small bug: pasted structure is here to stay when the mouse is moving outside the canvas.
Steps to Reproduce
- Cut or copy a structure
Ctrl+vto paste it on the canvas- Move the mouse to the toolbar
Actual behavior
The pasted structure is still here
Expected behavior
The pasted structure disappears. The following GIF is created on v2.7.0 RC test remote version.
There was a problem hiding this comment.
Do we have explicit requirements to remove it when over a toolbar?
Why should we use controversial logic for different tools? We do not break selection when going over toolbars, why should we break copy-paste action?
There was a problem hiding this comment.
You are right. Actually, sometimes I'm a bit confused about some controversial logic. Thanks for your fast reply :)
There was a problem hiding this comment.
And please check out this one. The hand tool is still following the cursor when moving outside the canvas.
I'm not sure if it's caused by that line of code, but I guess it's because the mouseleave event is not triggered. The following code in ketcher-react/src/script/ui/views/components/StructEditor/StructEditor.jsx may help.
case 'leave':
this.editorRef.current.classList.remove(classes.enableCursor)
this.setState({
enableCursor: false
})
breakThere was a problem hiding this comment.
Yeah, that does look weird. Thanks for noticing.
I think it deserves its own issue on the board. I'll look into it later.
Now selection tool does not break when cursor leaves canvas.
Fixes #2060