Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With each addition of FG to FG connected to terminal atoms of structure, bond disappears and structure decreases #2269

Closed
Zhirnoff opened this issue Feb 24, 2023 · 0 comments · Fixed by #2290
Closed

With each addition of FG to FG connected to terminal atoms of structure, bond disappears and structure decreases #2269

Zhirnoff opened this issue Feb 24, 2023 · 0 comments · Fixed by #2290
Assignees
@yuleicul @KonstantinEpam23
Labels
bug
Milestone
Ketcher 2.8.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 24, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add 'Chain' on canvas
  3. Add any Functional Group to terminal atom of Chain
  4. Add any FG to early added FG

Actual behavior
When adding a functional group to terminal atoms of a chain, bond between functional group and the chain disappears and chain is shortened with each subsequent addition of a functional group. Same behavior with 'Bonds'

Expected behavior
When adding a functional group to terminal atoms of a chain, bond between functional group and chain not disappears and chain is not shortened with each subsequent addition of a functional group. Adding FG replace FG connected to 'Chain'.

Screenshots

2023-02-24_11h58_38.mp4
2023-02-24_12h12_40.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.4

Additional context
Related issue: #1953
@Zhirnoff Zhirnoff added the bug label Feb 24, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.8.0-rc.5 milestone Feb 24, 2023
@Zhirnoff Zhirnoff mentioned this issue Feb 24, 2023
Closed
@yuleicul yuleicul mentioned this issue Mar 2, 2023
Merged
@yuleicul yuleicul linked a pull request Mar 2, 2023 that will close this issue
#2269 with each addition of fg to fg connected to terminal atoms of structure bond disappears and structure decreases #2290
Merged
KonstantinEpam23 added a commit that referenced this issue Mar 6, 2023
@KonstantinEpam23 @yuleicul
Backmerge: #2269 with each addition of fg to fg connected to terminal…
28bf82d 
… atoms of structure bond disappears and structure decreases (#2297)

* Fix bond disappearing when replacing f-group with another f-group (#2290)

* Remove clicked S-Group

---------

Co-authored-by: Yulei Chen <yulei_chen@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

@KonstantinEpam23 KonstantinEpam23

Labels
bug
Projects
None yet
Milestone
Ketcher 2.8.0-rc.5
4 participants
@yuleicul @Nitvex @Zhirnoff @KonstantinEpam23