Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment points should be within R-Group brackets #197

Closed
ElenaKlepova opened this issue Dec 21, 2020 · 1 comment · Fixed by #2888
Closed

Attachment points should be within R-Group brackets #197

ElenaKlepova opened this issue Dec 21, 2020 · 1 comment · Fixed by #2888
Assignees
@StarlaStarla
Labels
enhancement Priority: Low
Milestone
Ketcher 2.13.0-rc.1

Comments

@ElenaKlepova
Copy link

Description:
When attachment points are attached to a structure that is a R-Group member, the attachment points are beyond the R-Group brackets.

Steps to reproduce:

  1. Create a structure.
  2. Make the structure a R-Group member using R-Group Fragment Tool.
  3. Attach attachment points to the structure using Attachment Point Tool.

Actual result:
Attachment points are beyond R-Group brackets.
2020-12-21_17h17_11

Expected result:
Attachment points are within R-Group brackets.
@AndreiMazol AndreiMazol added this to the Backlog milestone Apr 21, 2021
@Zhirnoff Zhirnoff modified the milestones: Backlog, Ketcher 2.13.0-rc.1 Jun 20, 2023
@Zhirnoff
Copy link
Collaborator

After we switched to attachment point visualization to IUPAC style, attachment points began to protrude more than before beyond the brackets of the R-group and overlap some elements of the structure. Attachment points must be completely closed by brackets and they must not protrude beyond their borders.
2023-06-20_18h23_36
2023-06-20_18h24_45

@Nitvex Nitvex assigned StarlaStarla and unassigned Nitvex Jul 5, 2023
StarlaStarla added a commit that referenced this issue Jul 7, 2023
@StarlaStarla
#197 - Attachment points should be within R-Group brackets
fdae757
@StarlaStarla StarlaStarla linked a pull request Jul 7, 2023 that will close this issue
#197 - Attachment points should be within R-Group brackets #2888
Merged
7 tasks
@StarlaStarla StarlaStarla mentioned this issue Jul 7, 2023
Merged
7 tasks
StarlaStarla added a commit that referenced this issue Jul 7, 2023
@StarlaStarla
#197 - enhancement of code
6747051
StarlaStarla added a commit that referenced this issue Jul 10, 2023
@StarlaStarla
#197 - revert changes
8aed5b4
rrodionov91 added a commit that referenced this issue Jul 18, 2023
@rrodionov91
Merge pull request #2888 from epam/197-attachment-points-should-be-wi…
52ab1f6 
…thin-r-group-brackets

#197 - Attachment points should be within R-Group brackets
StarlaStarla added a commit that referenced this issue Jul 19, 2023
@StarlaStarla
#197 - fix s-group attachment points protruding brackets and add unit…
8cef7ce 
… tests
@StarlaStarla StarlaStarla linked a pull request Jul 19, 2023 that will close this issue
#197 - attachment points should be within r group brackets #2935
Closed
8 tasks
StarlaStarla added a commit that referenced this issue Jul 24, 2023
@StarlaStarla
#197 - fix s-group attachment points protruding brackets and add unit…
bee27f8 
… tests
StarlaStarla added a commit that referenced this issue Jul 24, 2023
@StarlaStarla
#197 - fix s-group attachment points protruding brackets and add unit…
7ed0263 
… tests
StarlaStarla added a commit that referenced this issue Jul 24, 2023
@StarlaStarla
#197 - fix s-group attachment points protruding brackets and add unit…
5f04e52 
… tests
@StarlaStarla StarlaStarla mentioned this issue Jul 24, 2023
Closed
8 tasks
@yuleicul yuleicul mentioned this issue Jul 25, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
enhancement Priority: Low
Projects
None yet
Milestone
Ketcher 2.13.0-rc.1
5 participants
@StarlaStarla @Nitvex @Zhirnoff @AndreiMazol @ElenaKlepova