Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2949 - Attachment points should be within S-Group brackets #2951

Conversation

StarlaStarla
Copy link
Collaborator

@StarlaStarla StarlaStarla commented Jul 24, 2023

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"

@StarlaStarla StarlaStarla linked an issue Jul 24, 2023 that may be closed by this pull request
@StarlaStarla StarlaStarla changed the title # 2949 attachment points should be within s group brackets # 2949 - Attachment points should be within S-Group brackets Jul 24, 2023
@StarlaStarla StarlaStarla force-pushed the 2949-attachment-points-should-be-within-s-group-brackets branch 2 times, most recently from 7ed0263 to 5f04e52 Compare July 24, 2023 02:53
@StarlaStarla StarlaStarla force-pushed the 2949-attachment-points-should-be-within-s-group-brackets branch from 5f04e52 to b9599cf Compare July 24, 2023 02:59
@StarlaStarla StarlaStarla reopened this Jul 24, 2023
@StarlaStarla StarlaStarla changed the title # 2949 - Attachment points should be within S-Group brackets #2949 - Attachment points should be within S-Group brackets Jul 24, 2023
@StarlaStarla
Copy link
Collaborator Author

pull request base branch is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attachment points should be within S-Group brackets
1 participant