fix: Wrong loading state with no permissions

src/pages/cdpipeline-list/components/CDPipelineList/index.tsx

@@ -18,7 +18,7 @@ export const CDPipelineList = ({ filterFunction, blockerComponent }: CDPipelineL
 
   return (
     <Table
-      isLoading={CDPipelines.isLoading}
+      isLoading={CDPipelines.isLoading && (!CDPipelines.errors || !CDPipelines.errors.length)}
       data={CDPipelines.data}
       errors={CDPipelines.errors}
       columns={columns}

src/pages/component-details/components/CodebaseBranchesList/components/CodebaseBranch/components/Details/index.tsx

@@ -13,7 +13,7 @@ import {
 import { useTypedPermissions } from '../../../../../../hooks/useTypedPermissions';
 import { DetailsProps } from './types';
 
-export const Details = ({ pipelineRuns }: DetailsProps) => {
+export const Details = ({ pipelineRuns, error }: DetailsProps) => {
   const permissions = useTypedPermissions();
 
   return (
@@ -32,7 +32,7 @@ export const Details = ({ pipelineRuns }: DetailsProps) => {
               >
                 <PipelineRunList
                   pipelineRuns={pipelineRuns.all}
-                  isLoading={pipelineRuns.all === null}
+                  isLoading={pipelineRuns.all === null && !error}
                   permissions={permissions}
                   pipelineRunTypes={[
                     PIPELINE_TYPES.ALL,

src/pages/component-details/components/CodebaseBranchesList/components/CodebaseBranch/components/Details/types.ts

@@ -7,4 +7,5 @@ export interface DetailsProps {
     all: PipelineRunKubeObjectInterface[];
     latestBuildPipelineRun: PipelineRunKubeObjectInterface;
   };
+  error: Error;
 }

src/pages/component-details/components/CodebaseBranchesList/components/CodebaseBranch/index.tsx

@@ -30,7 +30,7 @@ export const CodebaseBranch = ({
     latestBuildPipelineRun: null,
   });
 
-  const [, setError] = React.useState<Error>(null);
+  const [error, setError] = React.useState<Error>(null);
 
   const handleStorePipelineRuns = React.useCallback(
     (socketPipelineRuns: PipelineRunKubeObjectInterface[]) => {
@@ -92,7 +92,7 @@ export const CodebaseBranch = ({
           <Summary codebaseBranchData={codebaseBranchData} pipelineRuns={pipelineRuns} />
         </AccordionSummary>
         <AccordionDetails>
-          <Details codebaseData={codebaseData} pipelineRuns={pipelineRuns} />
+          <Details codebaseData={codebaseData} pipelineRuns={pipelineRuns} error={error} />
         </AccordionDetails>
       </Accordion>
     </div>

src/pages/component-list/components/ComponentList/index.tsx

@@ -128,7 +128,7 @@ export const ComponentList = ({ noGitServers }: ComponentListProps) => {
     <>
       <Resources />
       <Table<CodebaseKubeObjectInterface>
-        isLoading={codebases.isLoading}
+        isLoading={codebases.isLoading && (!codebases.errors || !codebases.errors.length)}
         data={codebases.data}
         errors={codebases.errors}
         columns={columns}

src/pages/configuration/pages/pipeline-list/view.tsx

@@ -16,7 +16,7 @@ export const PageView = () => {
     namespace: getDefaultNamespace(),
   });
 
-  const isLoading = items === null;
+  const isLoading = items === null && !error;
 
   return (
     <PageWithSubMenu list={menu} title="Configuration">

src/pages/configuration/pages/quicklinks/components/ComponentList/index.tsx

@@ -9,7 +9,7 @@ export const QuickLinkList = ({ items, errors, filterFunction }: QuickLinkListPr
   return (
     <>
       <Table
-        isLoading={!items}
+        isLoading={items === null && (!errors || !errors.length)}
         data={items}
         errors={errors}
         columns={columns}

src/pages/configuration/pages/task-list/view.tsx

@@ -16,7 +16,7 @@ export const PageView = () => {
     namespace: getDefaultNamespace(),
   });
 
-  const isLoading = items === null;
+  const isLoading = items === null && !error;
 
   return (
     <PageWithSubMenu list={menu} title="Configuration">

src/pages/marketplace/components/MarketplaceList/components/TemplatesTable/index.tsx

@@ -21,7 +21,7 @@ export const TemplatesTable = ({
       errors={errors}
       columns={columns}
       data={data}
-      isLoading={data === null}
+      isLoading={data === null && (!errors || !errors.length)}
       handleRowClick={
         permissions?.create?.Codebase.allowed ? (event, row) => handleTemplateClick(row) : null
       }

src/pages/marketplace/components/MarketplaceList/index.tsx

@@ -49,7 +49,7 @@ export const MarketplaceList = ({ filterFunction, warning }: MarketplaceListProp
         <DataGrid<TemplateKubeObjectInterface>
           data={templates.data}
           errors={templates.errors}
-          isLoading={templates.isLoading}
+          isLoading={templates.isLoading && (!templates.errors || !templates.errors.length)}
           spacing={3}
           filterFunction={filterFunction}
           emptyListComponent={

src/pages/pipelines/view.tsx

@@ -33,7 +33,9 @@ export const PageView = () => {
         >
           <PipelineRunList
             pipelineRuns={pipelineRuns.data}
-            isLoading={pipelineRuns.isLoading}
+            isLoading={
+              pipelineRuns.isLoading && (!pipelineRuns.errors || !pipelineRuns.errors.length)
+            }
             errors={pipelineRuns.errors}
             permissions={permissions}
           />

src/pages/stage-details/hooks/usePageTabs.tsx

@@ -139,7 +139,7 @@ export const usePageTabs = (): Tab[] => {
               >
                 <PipelineRunList
                   pipelineRuns={pipelineRuns.data}
-                  isLoading={pipelineRuns.isLoading}
+                  isLoading={pipelineRuns.isLoading && !pipelineRuns.error}
                   blockerError={pipelineRuns.error}
                   permissions={permissions}
                   pipelineRunTypes={[
@@ -214,6 +214,7 @@ export const usePageTabs = (): Tab[] => {
     pipelineRuns.error,
     pipelineRuns.isLoading,
     setNewPipelineRunAdded,
+    stage.data?.spec.clusterName,
     stage.data?.spec.namespace,
     stageName,
     variablesConfigMap.data,