Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong loading state with no permissions #547

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

callmevladik
Copy link
Contributor

Pull Request Template

Description

When user doesn't have permissions to load some resources, user sees loading indicator even when a request is done.

Fixes #546

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

Screenshots (if appropriate):

Additional context

Add any other context or screenshots about the feature request here.

@callmevladik callmevladik added the bug Something isn't working label Jan 13, 2025
@callmevladik callmevladik self-assigned this Jan 13, 2025
@callmevladik callmevladik requested a review from a team as a code owner January 13, 2025 15:34
@MykolaMarusenko MykolaMarusenko merged commit fb6e87a into master Jan 13, 2025
6 checks passed
@MykolaMarusenko MykolaMarusenko deleted the fix/wrong-loading-state-with-no-permissions branch January 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix wrong loading state when user has no right to load ResourceList
3 participants