Start using a list of verses pre-selected by the community #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a JSON schema to validate the structure and uniqueness of verses. This addition not only provides intellisense for future contributors but also ensures that each item contains the necessary: abbreviation, chapter, and verse, and that there are no duplicate verses. This promotes greater data integrity within the project.
This addition implements validation of `verses.json` against `verses.schema.json` using ajv-cli in Husky's pre-commit. This ensures the integrity and consistency of the verses in the project with each commit, ensuring that only "valid" data is sent to the repository. Additionally, the execution of the linting script has been included in the pre-commit to maintain code quality. The setup of @commitlint/cli and @commitlint/config-conventional has also been configured, providing a consistent pattern for commit messages ensured by Husky.
Now, the API URL is defined through an environment variable, allowing flexibility to use different URLs according to the execution environment. Also implements type and validation of environment variables. Additionally, adds a function to facilitate and abstract requests to our API routes for better code organization and readability.
…rsículos-bíblicos Aprimorando a seleção de versículos bíblicos
feat: add eslint check and fix scripts feat: Refactor the countdown to better maintainability fix: fix counter not refreshing when running router.refresh()
Refactor the countdown code and fix some bugs, also implements error handling for api call.
This is a list of 365 verses pre-selected by the community. Thank you to everyone who contributed! Romans 11:36 --------- Co-authored-by: Gabriel Cursino <gabrielcursino.medeiros@gmail.com> Co-authored-by: Johan Vilela <johanvilela@hotmail.com> Co-authored-by: Clóvis Daniel Souza Silva <clovisdanielss@gmail.com> Co-authored-by: Thales Gomes Targino <thalestargino@gmail.com> Co-authored-by: Joao Paulo Alencar Rodrigues <joao.paulo@inovan.do> Co-authored-by: Marcelo <97993630+Mmarcelinho@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modifications to this PR cause the application to start using a list of verses pre-selected by the community, bringing more context to the verses.
Also fixed is the countdown refresh bug, as well as a refactoring to improve the maintainability of the component.