Refatora o código do Countdown #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add eslint check and fix scripts feat: Refactor the countdown to better maintainability fix: fix counter not refreshing when running router.refresh()
|
@hiroshimorowaka is attempting to deploy a commit to the Salinas' projects Team on Vercel. A member of the Team first needs to authorize it. |
eoSalinas
reviewed
Apr 8, 2024
There was a problem hiding this comment.
A tratativa de erro ficou muito boa. Ter um placeholder é uma excelente alternativa, e estavamos precisando mesmo cuidar com essa chamada, excelente trabalho!
| export default async function Home() { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const cookie = cookies() // Just to force a dynamic route for get the right time to countdown | ||
| export const dynamic = 'force-dynamic' // Force dynamic rendering for SSR |
|
Ahh antes que eu esqueça, assim que eu sair do trabalho vou lá na issue #15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que foi feito
countdown.tsxpara aumentar a manutenibilidadeNenhuma mudança estética foi feita, apenas lógica do código e refatorações devido a issue #15