Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bandaid fix to fix CI failures #64

Merged
merged 2 commits into from
Sep 13, 2016
Merged

Bandaid fix to fix CI failures #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e21c13b
Bandaid fix to fix CI failures
Sep 13, 2016
642f582
Update admin_test.cc
mattklein123 Sep 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/server/http/admin_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ namespace Server {

class AdminFilterTest : public testing::Test {
public:
//TODO: change the port. This is a hacky fix for CI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// TODO: Switch to mocks and don't use real port.

AdminFilterTest()
: admin_("/dev/null", 9001, server_), filter_(admin_), request_headers_{{":path", "/"}} {
: admin_("/dev/null", 9002, server_), filter_(admin_), request_headers_{{":path", "/"}} {
filter_.setDecoderFilterCallbacks(callbacks_);
}

Expand Down