Bandaid fix to fix CI failures #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,8 +9,9 @@ namespace Server { | |||
|
|
|||
| class AdminFilterTest : public testing::Test { | |||
| public: | |||
| //TODO: change the port. This is a hacky fix for CI. | |||
There was a problem hiding this comment.
// TODO: Switch to mocks and don't use real port.
|
+1 |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
PiotrSikora
added a commit
to PiotrSikora/envoy
that referenced
this pull request
May 11, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
ghost
mentioned this pull request
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Resolves envoyproxy/envoy-mobile#39, envoyproxy/envoy-mobile#32, and envoyproxy/envoy-mobile#33. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Resolves envoyproxy/envoy-mobile#39, envoyproxy/envoy-mobile#32, and envoyproxy/envoy-mobile#33. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
arminabf
pushed a commit
to arminabf/envoy
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.