Reapply "udp: set Don't Fragment(DF) bit in IP packet header (#36341)" #36437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxy#36341)" This reverts commit ea1d345. Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
danzh2010
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
fredyw
as code owners
fredyw
reviewed
Oct 3, 2024
| @@ -1330,7 +1330,7 @@ TEST_P(ClientIntegrationTest, TestProxyResolutionApi) { | |||
|
|
|||
| // This test is simply to test the IPv6 connectivity check and DNS refresh and make sure the code | |||
| // doesn't crash. It doesn't really test the actual network change event. | |||
| TEST_P(ClientIntegrationTest, OnNetworkChanged) { | |||
| TEST_P(ClientIntegrationTest, OnNetworkChanged1) { | |||
There was a problem hiding this comment.
This is to trigger mobile tests. Looks like the tests are still failing due to bulk transfer error: https://github.com/envoyproxy/envoy/actions/runs/11166604324/job/31041663403
There was a problem hiding this comment.
In fact, those failures look weird, can you take a look?
There was a problem hiding this comment.
I believe it's related to #36426 (the issue, not the PR). The flakiness is still there caused by AndroidEngineExplicitFlowTest.post_multipleRequests_randomBehavior. Let me take a closer look at it further. For the time being, you just may need to retest.
|
/retest |
danzh2010
changed the title
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: removed the static_assert as it is expected that some platform, especially some iOS versions supports neither of the socket options. In this case, Envoy wont' set DF bit.
Additional Description: reland #36341
Risk Level: low
Testing: new unit tests
Docs Changes: N/A
Release Notes: Yes
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.udp_set_do_not_fragment